perf: Rewrite get_fock_space_basis
#361
Merged
+71
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for the function `get_fock_space_basis` got rewritten to reuse allocated memory and calculate array sizes in advance. For this, some functions in `fock.py` got JITted. Moreover, the utility function `cutoff_cardinality` got renamed to `cutoff_fock_space_dim` being a more fitting name. Moreover, `powerset` got deleted from the production code, since it is not used anymore.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 72 72
Lines 3842 3842
=======================================
Hits 3757 3757
Misses 85 85 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for the function
get_fock_space_basisgot rewritten to reuse allocated memory and calculate array sizes in advance. For this, some functions infock.pygot JITted. Moreover, the utility functioncutoff_cardinalitygot renamed tocutoff_fock_space_dimbeing a more fitting name. Moreover,powersetgot deleted from the production code, since it is not used anymore.